refactor: add lazy field to LibraryCollectionData - #404
Conversation
This is required to handle the signal asynchronously whenever the sender does not care about the handler execution completion. For example, whenever multiple collections are updated due to a component being added or removed, we do not want to wait for all collection update handlers to complete.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
rpenido
left a comment
rpenido
left a comment
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from: openedx/frontend-app-authoring#1373
- I read through the code
-
I checked for accessibility issuesN/A - Includes documentation
|
@felipemontoya @mariajgrimaldi @brian-smith-tcril Could you review this as CC? Thanks! |
|
@mariajgrimaldi Would you mind merging for us? I don't think we have permission. |
|
@bradenmacdonald: @navinkarkera has merge rights. But yes, I’ll merge as soon as I can - I'm seeing this from my phone. |
|
@mariajgrimaldi Thank you! |
This is required to handle the signal asynchronously whenever the sender does not care about the handler execution completion. For example, whenever multiple collections are updated due to a component being added or removed, we do not want to wait for all collection update handlers to complete.
6 participants
This is required to handle the signal asynchronously whenever the sender does not care about the handler execution completion.
For example, whenever multiple collections are updated due to a component being added or removed, we do not want to wait for all collection update handlers to complete.
Dependencies:
Merge deadline: ASAP
Testing instructions:
Merge checklist:
Post merge:
finished.