fix: change variables names to match repository purpose - #11
Merged
Conversation
magajh
approved these changes
Aug 18, 2021
|
@mariajgrimaldi is it possible to add the link to the discussion in the description? |
magajh
reviewed
Aug 18, 2021
| Arguments: | ||
| hook_name (str): determines which trigger we are listening to. | ||
| filter_name (str): determines which trigger we are listening to. | ||
| It also specifies which hook configuration defined through settings. |
There was a problem hiding this comment.
@mariajgrimaldi is this line ok?
It also specifies which hook configuration defined through settings.
andrey-canon
approved these changes
Aug 22, 2021
mariajgrimaldi
force-pushed
the
MJG/remove_names
branch
4 times, most recently
from
September 3, 2021 14:37
bc01b6b to
9c5a94d
Compare
mariajgrimaldi
force-pushed
the
MJG/remove_names
branch
from
September 3, 2021 14:45
9c5a94d to
c66b02a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes hook to filter and standardizes the configuration name.