Acceptance criteria:
Course asset URLs like /asset-v1:... are served from a middleware at openedx.core.djangoapps.contentserver.middleware.StaticContentServer rather than from a view. This means that Django starts handling the request as a Not Found (because there is no matching urlpattern), but then the middleware intercepts the request and returns a response of its own. There wasn't any good reason for doing this instead of using a view, as far as I can tell. It causes some problems for telemetry: When the code-owner middleware asks Django what view handled the request, it does so by looking at the result of the resolve utility, but these URLs get a Resolver404 (because there's no registered urlpattern).
Implementation suggestion:
- Register equivalent urlpatterns and a view that calls into the same code the middleware currently contains.
- Add a Waffle flag that causes the middleware to fall through to the view.
- Try turning the flag on.
- Remove the middleware so that the view is always used.
- [Beyond this ticket:] Bring the new view's code up to standards (better use of urlpatterns, etc.)
PRs:
Acceptance criteria:
IMPLvariable andStaticContentServerclass by lifting methods to module scopeCourse asset URLs like
/asset-v1:...are served from a middleware atopenedx.core.djangoapps.contentserver.middleware.StaticContentServerrather than from a view. This means that Django starts handling the request as a Not Found (because there is no matching urlpattern), but then the middleware intercepts the request and returns a response of its own. There wasn't any good reason for doing this instead of using a view, as far as I can tell. It causes some problems for telemetry: When the code-owner middleware asks Django what view handled the request, it does so by looking at the result of theresolveutility, but these URLs get a Resolver404 (because there's no registered urlpattern).Implementation suggestion:
PRs: