[Test failure] TC_LEARNER_12: Facebook sign in from account page returns 404 when linking account

[mariajgrimaldi]

Release

Teak

Expected behavior

After succesfully authenticated, the auth process redirects the user to the account MFE page

Actual behavior

The user is redirected to /accounts/settings which is currently deprecated, so the auth process doesn't complete successfully. In consequence, the user can't link their account to facebook - as for now, for some reason google auth process works from the account page works correctly.

Video recording:

Screencast.from.05-06-25.13.44.12.webm

Steps to reproduce

1. Configure Facebook as an oauth provider. You can follow these instructions to do so: https://developers.facebook.com/docs/facebook-login/, https://docs.openedx.org/en/latest/site_ops/install_configure_run_guide/configuration/tpa/tpa_integrate_open/tpa_oauth.html#register-the-open-edx-instance-with-facebook
2. Login using your credentials
3. Go to your account
4. Try to link your facebook account to the Open edX account

Additional information

I did some research and I think this is happening because the auth_entry used for the auth process points to /account/settings instead of account/ - this is only an assumption, though.

 URLs associated with auth entry points
# These are used to request additional user information
# (for example, account credentials when logging in),
# and when the user cancels the auth process
# (e.g., refusing to grant permission on the provider's login page).
# We don't use "reverse" here because doing so may cause modules
# to load that depend on this module.
AUTH_DISPATCH_URLS = {
    AUTH_ENTRY_LOGIN: '/login',
    AUTH_ENTRY_REGISTER: '/register',
    AUTH_ENTRY_ACCOUNT_SETTINGS: '/account/settings',
}

https://github.com/openedx/edx-platform/blob/8a65d224bb13034a82cf271e00feaf2f5def7109/common/djangoapps/third_party_auth/pipeline.py#L148-L159

[mariajgrimaldi]

Hey, @crathbun428! Can you give a hand with prioritizing this issue? Thanks!

[mariajgrimaldi]

I think what we should do is:

1. Change /account/settings to /account
2. Redirect /account to the account MFE, just like /login /register do

What I don't really know is how linking google works from the account MFE but Facebook doesn't, not sure what the difference is, or whether I'm missing something.