Hotfix/2015 10 15 - #10195
Conversation
…NL-2395, TNL-2394, TNL-2393
The heart of this fix is to change the "My Team" view to use a collection of teams instead of memberships. The team card is refactored to only take a team, rather than attempt to be polymorphic over teams and team memberships. This change enabled removing a good amount of old code. This also requires adding a `username` parameter to the teams list endpoint which allows getting a list of all teams for a single user, in order to allow refreshing the "My Teams" view correctly. Currently this list is of length at most one. TNL-3410
|
Looks like test are failing because migrations didn't run... |
|
@jzoldak , @benpatterson , should I just rerun tests to trigger a migration? |
|
@adampalay for the python test failures? I don't think rerunning jenkins jobs would help... |
|
@benpatterson it looks like tests failed because a migration wasn't run — do you know how to get the migrations to run? |
|
jenkins run python please |
|
@adampalay if "running it again" will solve this problem, then we should still fix it. Because we'd be introducing a flaky pattern and, once rebased, developers would be running python multiple times to get a passing build. |
|
@benpatterson, good point. It looks like tests failed a second time soon anyway. @bderusha |
|
@adampalay @bderusha if this helps, I can reproduce locally by running |
|
@benpatterson oh, interesting. I couldn't reproduce by running |
|
jenkins run bokchoy |
|
The failed bokchoy test is known to be flaky, and doesn't need to hold up this hotfix release: https://openedx.atlassian.net/browse/TNL-3489 Link to failure on previous run: https://build.testeng.edx.org/job/edx-platform-bok-choy-pr/6463/ |
|
Working with @bderusha , we discovered that the python test failures were because third_party_auth isn't configured in CMS, so we're going to skip these tests if |
Fix quality for template escaping
…-not-installed skip LTIConfig test when third_party_auth is not installed
|
Ok, in theory, everything should pass now! |
7 participants
@bradenmacdonald
@jibsheet