Minor cleanup. - #1030
Merged
Merged
Conversation
Contributor
|
Huh; I don't know what the issue is with 👍 |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Aug 9, 2016
…ix-requirement-version Fix requirements version openedx#854
afzaledx
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jun 1, 2018
…ision [MCKIN-6965] Newly Added Drag and Drop blocks not loading in Studio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@singingwolfboy A couple of minor things I noticed while using the textbooks as an example for assets.
The _.result syntax isn't working. I'm not sure why, but the asserts always pass, no matter what you are testing for. Calling the methods directly seems simpler anyway.
Related to Put back in the blocks for Advanced Settings. #1, the URL key was wrong for CMS.Collections.TextbookSet.
Calling destroy on a model removes it from the collection automatically.