Skip to content

Update problem-builder to version 2.0.3 (release) - #11804

Closed
omarkhan wants to merge 1 commit into
openedx:releasefrom
open-craft:omar/update-problem-builder
Closed

Update problem-builder to version 2.0.3 (release)#11804
omarkhan wants to merge 1 commit into
openedx:releasefrom
open-craft:omar/update-problem-builder

Conversation

@omarkhan

Copy link
Copy Markdown
Contributor

Bug

The 'Download report' link on the problem builder dashboard is currently broken. Images are not always displayed, for 2 reasons:

  • If the image is from a different domain and it has been cached by the browser, it is not converted into a data URL due to cross-domain security issues. A javascript SecurityError is thrown, and nothing happens.
  • If the image url starts with // (no explicit protocol) or the url is relative (e.g. /static/...), and it has not yet been cached by the browser, it will fail to show up in the downloaded report.

Fix

These issues have been fixed in version 2.0.3 of problem builder (see open-craft/problem-builder#106). This pull request updates edx-platform to use the new version.

Partner information

Harvard GSE course hosted on edx.org (Data Wise)

Merge deadline

ASAP, affecting students in live course

Settings

edx_platform_version: 'omar/update-problem-builder-sandbox'

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @omarkhan! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?number=11804&repo=edx%2Fedx-platform

@Kelketek

Copy link
Copy Markdown
Contributor

👍

@bradenmacdonald

Copy link
Copy Markdown
Contributor

Note: this PR is against the release branch but we haven't yet confirmed if this will be released as a hotfix.

@omarkhan omarkhan changed the title Update problem-builder to version 2.0.3 Update problem-builder to version 2.0.3 (release) Mar 16, 2016
@omarkhan

Copy link
Copy Markdown
Contributor Author

See also https://github.com/edx/edx-platform/pull/11818 against the master branch.

@omarkhan

Copy link
Copy Markdown
Contributor Author

Closing owing to difficulty in provisioning a sandbox for the release branch of edx-platform.

@omarkhan omarkhan closed this Mar 17, 2016
@bradenmacdonald
bradenmacdonald deleted the omar/update-problem-builder branch May 18, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants