mattdrayer/theme-ecommerce-url: Theme support for ECOMMERCE_PUBLIC_URL_ROOT - #11954
Merged
Conversation
…C_URL_ROOT setting
Contributor
|
@mattdrayer thanks - although it was slightly not enough for it to work - I've added the missing parts and sent a PR against this branch: https://github.com/edx/edx-platform/pull/11966 |
Contributor
|
@mattdrayer 👍 changes look good to me |
Contributor
Author
|
Cool -- going ahead with the merge and we will take this setting into account along with the rest when we move to the new SiteConfiguration approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP branch -- @e-kolpakov @saleem-latif -- FYI