Revert "Remove ThemingAware storage mixins and ComprehensiveThemeFind… - #12128
Merged
Conversation
…er." This reverts commit 266f593.
Contributor
|
👍 |
Contributor
|
@mattdrayer 👍, thank you for tracking this down. Please go ahead and merge. We'll let tests run on the RC. |
Contributor
|
This makes sense. That commit was a workaround for collectstatic issues we were experiencing before support for multiple themes existed. It was never going to work with multiple themes. |
Contributor
Author
|
It didn't work, however, even with single themes -- ie, we reverted the multi-theme commit from the RC and continued to experience issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "Remove ThemingAware storage mixins and ComprehensiveThemeFinder."
This reverts commit 266f593, aka PR #11319.
We were experiencing issues with static asset compilation and originally thought the issue was due to the rather large #11885 change set. However, after reverting that PR we continued to observe issues with image and stylesheet selection, which led us back to this commit. So it has taken a couple days to track down what we think is the cause and we are hopeful that we have figured out what is going on.
@rlucioni @douglashall @saleem-latif @mtyaka FYI