Revert "Revert "saleem-latif/WL-328: Multi-Site Comprehensive Theming"" - #12218
Closed
mattdrayer wants to merge 1 commit into
Closed
Revert "Revert "saleem-latif/WL-328: Multi-Site Comprehensive Theming""#12218mattdrayer wants to merge 1 commit into
mattdrayer wants to merge 1 commit into
Conversation
Contributor
|
👍 |
Contributor
|
I'm getting a strange feeling of deja vu... |
Contributor
Author
|
Haha, hopefully this is the last time! |
Contributor
Author
|
jenkins run lettuce |
saleem-latif
force-pushed
the
patch/2016-04-21
branch
from
April 22, 2016 13:55
4df7d96 to
e04904f
Compare
Contributor
Author
There was a problem hiding this comment.
Is this the best way to access the request context at this location? I've seen other approaches throughout the code as well -- for example via threading -- for an example you can see django_sites_extensions.middleware.CurrentSiteWithDefaultMiddleware and how it is used in Otto (the middleware is also in LMS)
saleem-latif
force-pushed
the
patch/2016-04-21
branch
3 times, most recently
from
April 23, 2016 16:39
1232ec2 to
d5f1b06
Compare
saleem-latif
force-pushed
the
patch/2016-04-21
branch
from
April 24, 2016 05:41
d5f1b06 to
e6fbccd
Compare
Contributor
Author
|
Closed in favor of #12620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpennington @e0d @saleem-latif @andy-armstrong @douglashall @adampalay -- take 2 😄
This patch release contains the LMS multi-site theming feature implementation. It is dependent on the merge of edx/configuration#2970 and also requires some deploy-time updates for the COMPREHENSIVE_THEME_DIR and DEFAULT_SITE_THEME settings values.