Segregate the mongo db config from the modulestore config - #1240
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
Do we need mongo_options? Should they go into the db_store_config?
Contributor
There was a problem hiding this comment.
Yeah, I think the mongo_options should be in the doc_store_config.
Contributor
|
Other than minor comments, 👍 |
as a first step to separating db connection from modeling and to support location mapper and contentstore using same db config as modulestore
Contributor
Author
There was a problem hiding this comment.
@cpennington here's the replacement of mongo_options with doc_store_config using a nice pattern @singingwolfboy suggested (also in split.py)
Contributor
Author
|
@e0d waiting for your 👍 👎 note, if your yaml used 'mongo_options', move those fields to DOC_STORE_CONFIG |
Contributor
|
+1 |
dmitchell
added a commit
that referenced
this pull request
Oct 9, 2013
Segregate the mongo db config from the modulestore config
jarv
added a commit
that referenced
this pull request
Oct 10, 2013
Revert "Merge pull request #1240 from edx/dhm/config_separation"
dmitchell
pushed a commit
that referenced
this pull request
Oct 10, 2013
…on"" This reverts commit a517dc2.
dmitchell
pushed a commit
that referenced
this pull request
Oct 18, 2013
…on"" This reverts commit a517dc2.
dmitchell
added a commit
that referenced
this pull request
Oct 18, 2013
Revert "Revert "Merge pull request #1240 from edx/dhm/config_separation"...
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Dec 21, 2016
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Dec 21, 2016
* Fix enrollment_date for paid course openedx#1240 * Implements ga-self-paced for Studio openedx#1240 * Implements ga-self-paced courseware openedx#1240 * Fix review
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Dec 21, 2016
) * Change Studio background color for self-paced openedx#1240 * Fix review
lgp171188
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Nov 30, 2018
* Logs added to get status_code from forums * Updated comment * reverted to original state * Code intended * pep8 standards followed
lgp171188
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Nov 30, 2018
…enedx#1254) This reverts commit df95839.
iloveagent57
pushed a commit
that referenced
this pull request
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as a first step to separating db connection from modeling
and to support location mapper and contentstore using same db config as modulestore
@e0d please review
@chrisndodge @cpennington please review. Ed wanted to complete my separation of the db config from the modulestore config; so, rather than having the modulestore config as a subset of the db config, I separated them
and pass the db config as a dict instead of kwargs to modulestore inits.