DO NOT MERGE: disabling user accounts MVP - #1267
Closed
adampalay wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
It's best to end lists like this with a comma, and put the paren on the next line, so you don't have to edit the last line when adding a new last item.
Contributor
|
You have no tests! :( Need to test the new views you wrote, as well as the behavior of the login form if the user has been disabled. |
Contributor
Author
|
thanks @nedbat , I'm going to close this for now as I address all this. there's talk of moving this to the instr dash too. |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Oct 1, 2016
…ssages-of-entrance-exam Fix messages of entrance exam openedx#1266
lgp171188
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Nov 30, 2018
…estore-missing-completion-list-endpoint MCKIN-8437: Version bump api-integration to branch
iloveagent57
pushed a commit
that referenced
this pull request
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVP functionality to disable disruptive users:
Creates a UserStanding model, which is checked against each time a user logs in (if the user's account_status is disabled, they can't get in and they get an error message saying their account has been disabled)
Deletes all of that user's sessions, so whenever they navigate to another page they will be redirected to the login page.
The template is very, very barebones, and right now the url isn't linked to anywhere. That can easily be changed by adding a link to the instruct dashboard tab. Alternatively, this functionality can be directly inserted into the instructor dashboard.
@nedbat
@e0d