Remove code related to Pearson Testing Centers - #1299
Conversation
|
🔥 KILL IT WITH FIRE 🔥 Er, I mean. Looks good to me. 👍 |
|
@jzoldak Saw one of the Pearson tests fail on my branch. So there's an additional reason to merge this :) |
|
The |
|
Okay, I didn't think that the TimeLimitModule was useful to anyone -- or at least that after eight months or so it had not been used by anyone other than a pearson exam. But we could be conservative and leave it around. Problem with it is that there is little in the way of tests, so if it doesn't work (after various changes to xblocks, for instance), we probably woudn't notice. |
|
Correction -- seems there are some TimeLimitModule tests. So if the TimeLimitModule stuff were restored, there's still lots of Pearson stuff to go, and it doesn't look too entwined. |
|
The TImeLimitModule has been of interest to instructors at MIT, though we On Tue, Oct 29, 2013 at 11:32 AM, brianhw notifications@github.com wrote:
|
|
ping? What's going on with this old PR? |
|
The PR needs to be modified to not include the removal of TimeLimitModule. |
|
OK - if that's not going to be done anytime soon, can this PR be closed and re-opened when it's ready for re-consideration. Thanks. |
|
Rebasing now to get this re-ready to merge. Nobody that I know of now is using the current TimeLimitModule, and there are no integration tests for it. It could be broken by the ongoing XBlock / XModule shim work, and is one more thing to remember to test manually. If we need something like this it should be rewritten as an XBlock once XBlocks are in. |
|
Point taken. Let's go ahead with this PR to kill off Pearson-related code and put it on the backlog to bring back just the TimeLimitModule then. Thank you. |
|
@jzoldak I think one more rebase then it can be merged! |
|
@ormsbee I need someone to help with a migration. I've never done one, and that's what's been holding me back from completing this work. Can you help? |
Remove code related to Pearson Testing Centers
…k_poll_1.6.2 version bump xblock poll to 1.6.2
@brianhw