Skip to content

Remove code related to Pearson Testing Centers - #1299

Merged
jzoldak merged 3 commits into
masterfrom
zoldak/remove-pearson-code
Nov 27, 2013
Merged

Remove code related to Pearson Testing Centers#1299
jzoldak merged 3 commits into
masterfrom
zoldak/remove-pearson-code

Conversation

@jzoldak

@jzoldak jzoldak commented Oct 10, 2013

Copy link
Copy Markdown
Contributor

@singingwolfboy

Copy link
Copy Markdown
Contributor

🔥 KILL IT WITH FIRE 🔥

Er, I mean. Looks good to me. 👍

@wedaly

wedaly commented Oct 18, 2013

Copy link
Copy Markdown
Contributor

@jzoldak Saw one of the Pearson tests fail on my branch. So there's an additional reason to merge this :)

@ormsbee

ormsbee commented Oct 21, 2013

Copy link
Copy Markdown
Contributor

The TimeLimitModule actually seems like it would be pretty useful to keep around. Does that need to be killed here?

@brianhw

brianhw commented Oct 29, 2013

Copy link
Copy Markdown
Contributor

Okay, I didn't think that the TimeLimitModule was useful to anyone -- or at least that after eight months or so it had not been used by anyone other than a pearson exam. But we could be conservative and leave it around. Problem with it is that there is little in the way of tests, so if it doesn't work (after various changes to xblocks, for instance), we probably woudn't notice.

@brianhw

brianhw commented Oct 29, 2013

Copy link
Copy Markdown
Contributor

Correction -- seems there are some TimeLimitModule tests. So if the TimeLimitModule stuff were restored, there's still lots of Pearson stuff to go, and it doesn't look too entwined.

@ichuang

ichuang commented Oct 29, 2013

Copy link
Copy Markdown
Contributor

The TImeLimitModule has been of interest to instructors at MIT, though we
currently do not use it. This is for proctored exams, where students take
assessments online for credit in residential courses. If TimeLimitModule
were functional and documented we'd probably use it in the future.

On Tue, Oct 29, 2013 at 11:32 AM, brianhw notifications@github.com wrote:

Okay, I didn't think that the TimeLimitModule was useful to anyone -- or
at least that after eight months or so it had not been used by anyone other
than a pearson exam. But we could be conservative and leave it around.
Problem with it is that there is little in the way of tests, so if it
doesn't work (after various changes to xblocks, for instance), we probably
woudn't notice.


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1299#issuecomment-27313284
.

@sarina

sarina commented Nov 22, 2013

Copy link
Copy Markdown
Contributor

ping? What's going on with this old PR?

@brianhw

brianhw commented Nov 22, 2013

Copy link
Copy Markdown
Contributor

The PR needs to be modified to not include the removal of TimeLimitModule.

@sarina

sarina commented Nov 22, 2013

Copy link
Copy Markdown
Contributor

OK - if that's not going to be done anytime soon, can this PR be closed and re-opened when it's ready for re-consideration. Thanks.

@jzoldak

jzoldak commented Nov 25, 2013

Copy link
Copy Markdown
Contributor Author

Rebasing now to get this re-ready to merge.

Nobody that I know of now is using the current TimeLimitModule, and there are no integration tests for it. It could be broken by the ongoing XBlock / XModule shim work, and is one more thing to remember to test manually. If we need something like this it should be rewritten as an XBlock once XBlocks are in.

@ormsbee

ormsbee commented Nov 26, 2013

Copy link
Copy Markdown
Contributor

Point taken. Let's go ahead with this PR to kill off Pearson-related code and put it on the backlog to bring back just the TimeLimitModule then. Thank you.

@sarina

sarina commented Nov 26, 2013

Copy link
Copy Markdown
Contributor

@jzoldak I think one more rebase then it can be merged!

@jzoldak

jzoldak commented Nov 26, 2013

Copy link
Copy Markdown
Contributor Author

@ormsbee I need someone to help with a migration. I've never done one, and that's what's been holding me back from completing this work. Can you help?

jzoldak pushed a commit that referenced this pull request Nov 27, 2013
Remove code related to Pearson Testing Centers
@jzoldak
jzoldak merged commit bb3917f into master Nov 27, 2013
@jzoldak
jzoldak deleted the zoldak/remove-pearson-code branch November 27, 2013 12:35
giovannicimolin pushed a commit to open-craft/openedx-platform that referenced this pull request Dec 20, 2018
…k_poll_1.6.2

version bump xblock poll to 1.6.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants