Pull modal cover and date utils into their own files. - #1354
Merged
Conversation
Contributor
There was a problem hiding this comment.
This depends on "jquery.ui" and "jquery.timepicker"
Contributor
|
@singingwolfboy thanks for the heads up. after talking w @cahrens and @talbs I think this is fine to ship as-is in the vein of js cleanup, and plan to refactor and move these modals over to the notification framework in the near future. 👍 |
Move overview-specific functions into overview.js.
Contributor
|
I checked out the branch and played around with it a bit, and it looks good! 👍 |
cahrens
pushed a commit
that referenced
this pull request
Oct 24, 2013
Pull modal cover and date utils into their own files.
john2x
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 31, 2019
john2x
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 31, 2019
* Revert "version bump for scorm xblock (openedx#1354)" This reverts commit d465dc3. * Revert "Bump completion to v0.1.15 (openedx#1351)" This reverts commit 58932f3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also move overview code into overview.js.
@singingwolfboy I think this is ready for review now. I moved more code into overview.js....
Things to test: