Bulk Email improvements for release - #1359
Merged
Merged
Conversation
Contributor
Author
|
@sarina @flowerhack Please review. |
Contributor
|
Can you explain how this differs from the original prs? Also what PRs does this cover? |
Contributor
Author
|
@flowerhack It would be particularly helpful if you could try running this branch and just doing a sanity check that the new dash works as you expect. |
Contributor
|
Just finished looking over the dashboard stuff & ran it locally; everything seems to work as expected, so this looks a-OK from where I'm standing |
Contributor
|
OK makes sense to me |
set max enrollment for downloads to 200
Responses to Adam's comments; reset common.py, i18n compliance, deleted extraneous email.html file, fixed an HttpResponse, deleted unnecessary commented-out code, some small style tweaks
…n bulk_email subtasks.
…ts that needed it.
brianhw
added a commit
that referenced
this pull request
Oct 16, 2013
Bulk Email improvements for release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Contains the following PRs:
It does not contain a merge of PR 1260, but the code for that had already been merged into 1209.
The migration of 1322 and 1209 went smoothly. However, PR 1215 required some changes:
These were addressed in the first commit after the @flowerhack commits.