LMS: Revised CSS Architecture (resolves LMS_1020) - #1365
Merged
Conversation
brianhw
added a commit
that referenced
this pull request
Oct 16, 2013
LMS: Revised CSS Architecture (resolves LMS_1020)
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Oct 27, 2016
…tyle_reply_message_for_forum Fix font size that reply comments for discussion forum openedx#1362
john2x
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Feb 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This LMS work helps to:
This work brought up large concerns:
These two points really concern me and I highly recommend a very deep revamp/cleaning of the Sass architecture shortly. I've tested the display of many pages locally, but each page's display should really be stress-tested to ensure there are no visual regressions. If you want to test the number of rules being used, crack open your console and run this gist in a view - https://gist.github.com/psebborn/1885511
Per Rob/Miki, its been decided to merge this change into the release branch.