refactor studio component creation in acceptance tests - #1370
Merged
Conversation
Contributor
There was a problem hiding this comment.
I think the naming here is a little confusing. Intuitively, I'd think that a function called add_unit could be called multiple times to create several units; this implementation won't allow that.
Maybe something like setup_one_unit would be clearer: the function's job is to do everything necessary to ensure that the user is viewing a single unit, including creating the course, logging the user in, etc.
This should have a docstring as well.
Contributor
|
Some small style comments, but otherwise looks good. The tests are passing reliably for me locally. |
jzoldak
pushed a commit
that referenced
this pull request
Oct 16, 2013
refactor studio component creation in acceptance tests
giovannicimolin
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wedaly @singingwolfboy