Skip to content

Allow - ~ and . in course, branch, & block ids - #1386

Merged
dmitchell merged 1 commit into
masterfrom
dhm/bug-courseid
Oct 17, 2013
Merged

Allow - ~ and . in course, branch, & block ids#1386
dmitchell merged 1 commit into
masterfrom
dhm/bug-courseid

Conversation

@dmitchell

Copy link
Copy Markdown
Contributor

@chrisndodge @cahrens Please review. This is blocking Chris.

@chrisndodge

Copy link
Copy Markdown
Contributor

I'm not a regex-guy so I'll defer to Christina (do you know more). But looks good to me.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be updated.

@cahrens

cahrens commented Oct 17, 2013

Copy link
Copy Markdown

👍 Once tests pass.

dmitchell added a commit that referenced this pull request Oct 17, 2013
Allow - ~ and . in course, branch, & block ids
@dmitchell
dmitchell merged commit 2678f2a into master Oct 17, 2013
@dmitchell
dmitchell deleted the dhm/bug-courseid branch October 17, 2013 18:21
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Nov 14, 2016
* Fix message on dashboard openedx#1386

* Fix bug openedx#1390

* Add ut case.
jamestait pushed a commit to open-craft/openedx-platform that referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants