Convert course team management to new URL scheme. - #1467
Merged
Conversation
Author
There was a problem hiding this comment.
Note that has_access supports either new or old locations. But I must use old_location for verifying users registered in groups and enrolling staff in the course.
Contributor
|
To help track progress at least, can you move the url patterns for index and course_creator_request methods down to the new section in urls.py? |
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
Can you put these imports at the top of the template?
Contributor
|
Aside from import nitpicks, looks good to me. 👍 |
added 2 commits
October 24, 2013 14:01
Move RESTful URLs into our "done" section.
cahrens
pushed a commit
that referenced
this pull request
Oct 24, 2013
Convert course team management to new URL scheme.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Nov 27, 2016
* Implements ga_optional openedx#1239 (openedx#1393) * Fix has_terminated on course-overview. openedx#1324 (openedx#1391) * Version up CourseOverview to regenerate CourseOverview. * Add send_mail option to ContractAuth(biz) openedx#1322 (openedx#1392) * Revert "Revert "Merge pull request openedx#1298 from hachiyanagi-ks/develop/dogwood/…" (openedx#1394) * Version up django and ora2 openedx#1375 (openedx#1396) * Version up to django==1.8.16 openedx#1375 * Version up ora2 to gacco/eucalyptus==1.1.5 openedx#1375 * Add format file openedx#1428 (openedx#1465) * Text correction of scoring by instructor openedx#1467
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to test:
@singingwolfboy @dmitchell Please review (and check out the branch and test it!)
Note that I did NOT change the index and course_creator_request methods. Those looked "RESFful" enough to me. I moved course_creator_request down to the "new" section in urls.py. index was already there. Deleted listing, which duplicated index.