Introduce EnrollmentTrackUserPartition. - #14682
Closed
cahrens wants to merge 5 commits into
Closed
Conversation
cahrens
force-pushed
the
chrisitna/enrollment-track-user-partition2
branch
7 times, most recently
from
March 16, 2017 15:23
4fccf27 to
b490e55
Compare
cahrens
force-pushed
the
chrisitna/enrollment-track-user-partition2
branch
5 times, most recently
from
March 17, 2017 15:43
2168d09 to
f26fae8
Compare
cahrens
commented
Mar 18, 2017
| } | ||
| ] | ||
| self.assertEqual(self._get_partition_info(), expected) | ||
| self.assertEqual(self._get_partition_info(schemes=["cohort", "random"]), expected) |
Author
There was a problem hiding this comment.
Note to reviewers: exclude the enrollment_track partition.
cahrens
commented
Mar 18, 2017
| for user_partition in user_partitions: | ||
| for group in user_partition['groups']: | ||
| if str(group['id']) in xblock_display_name: | ||
| # Temporary hack until TNL-6731 is addressed. |
Author
There was a problem hiding this comment.
Note to reviewers: this issue will be fixed before this PR merges.
cahrens
commented
Mar 18, 2017
| self.course.user_partitions = [ | ||
| UserPartition( | ||
| id=0, | ||
| id=100, |
Author
There was a problem hiding this comment.
Note to reviewers: Changing IDs so they more accurately represent what the code does (and avoid non-unique IDs).
cahrens
commented
Mar 18, 2017
| 'skipped': 2 | ||
| } | ||
| with self.assertNumQueries(168): | ||
| with self.assertNumQueries(184): |
Author
There was a problem hiding this comment.
Note to reviewers: there are 8 different learners (increase of 2 queries per learner).
cahrens
force-pushed
the
chrisitna/enrollment-track-user-partition2
branch
from
March 20, 2017 14:44
ce5b9db to
3a540af
Compare
Author
|
jenkins run js |
1 similar comment
Author
|
jenkins run js |
cahrens
force-pushed
the
chrisitna/enrollment-track-user-partition2
branch
from
March 20, 2017 15:58
1294db5 to
04bf534
Compare
cahrens
force-pushed
the
chrisitna/enrollment-track-user-partition2
branch
from
March 21, 2017 16:41
cddb320 to
68d6efc
Compare
added 2 commits
March 21, 2017 12:41
Will need different change on review branch.
Change group to a method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #14731 for the version of this PR being removed (with "hacky UX commit" removed).