Skip to content

makes ajustments to modals on page load - #1473

Merged
adampalay merged 1 commit into
masterfrom
adam/fix/a11y-modal-management
Oct 24, 2013
Merged

makes ajustments to modals on page load#1473
adampalay merged 1 commit into
masterfrom
adam/fix/a11y-modal-management

Conversation

@adampalay

Copy link
Copy Markdown
Contributor

@symbolist : edx@cfaf127 actually broke the functionality in https://github.com/edx/edx-platform/pull/1401. I fixed it by having the js related to leanModal load once the page loads.

@dianakhuang

@dianakhuang

Copy link
Copy Markdown
Contributor

👍

@dianakhuang

Copy link
Copy Markdown
Contributor

BTW, I will rebase off of this once this gets merged.

@adampalay

Copy link
Copy Markdown
Contributor Author

or I can undo the changes in accessibility_tools and you'll add them to your PR--they're just aesthetic.

@symbolist

Copy link
Copy Markdown
Contributor

Oops! 👍

adampalay added a commit that referenced this pull request Oct 24, 2013
makes ajustments to modals on page load
@adampalay
adampalay merged commit 4257f71 into master Oct 24, 2013
@adampalay
adampalay deleted the adam/fix/a11y-modal-management branch October 24, 2013 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants