Skip to content

some i18n - #1481

Closed
PYushchenko wants to merge 6 commits into
openedx:masterfrom
smartdec:feature/i18n
Closed

some i18n#1481
PYushchenko wants to merge 6 commits into
openedx:masterfrom
smartdec:feature/i18n

Conversation

@PYushchenko

Copy link
Copy Markdown
Contributor

Some i18n in different modules displayed to student.

Comment thread common/templates/hinter_display.html Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pull the tags out of the string, or add a translator's note alerting the translator not to translate the tag?

@adampalay

Copy link
Copy Markdown
Contributor

@man2life , also, we don't want anything in common/templates or common/static to be dependent on django, so until we decide how we're going to go about translating the string there, don't worry about translating them.

@adampalay

Copy link
Copy Markdown
Contributor

@man2life , any updates on this PR?

@PYushchenko

Copy link
Copy Markdown
Contributor Author

@adampalay
Also i could remove from comit changes related to
common/templates/hinter_display.html
common/djangoapps/django_comment_common/models.py

@adampalay

Copy link
Copy Markdown
Contributor

@man2life, just for common/templates/hinter_display.html-- the djangoapps in common will still have dependencies

@sarina

sarina commented Nov 6, 2013

Copy link
Copy Markdown
Contributor

Something I've noticed in many of the common/templates & common/static files is comments around lines that will require i18n in the future - this would be a nice addition (since you've already identified them) to make short work of translating once we figure out a plan for these files.

@singingwolfboy

Copy link
Copy Markdown
Contributor

@man2life Looks like this pull request has conflicts, and needs to be rebased onto the latest master to resolve them. Do you know how to do that?

@sarina

sarina commented Nov 15, 2013

Copy link
Copy Markdown
Contributor

Still this PR will need to be rebased to resolve conflicts! Sorry :( but can you do so, so that we can get moving on merging more open source PRs? Thanks 😄

The tab names are not being translated
@sarina

sarina commented Nov 22, 2013

Copy link
Copy Markdown
Contributor

Hi,

is work on this pull request going to resume? If so please just put a comment in this PR (you can comment on the PR!) saying this is still active work. If I don't hear from you, however, we'll move to close this PR. You can re-open it when you resume work on this branch.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants