Modify program progress meter for use on detail pages - #14811
Merged
Conversation
Contributor
There was a problem hiding this comment.
what is this factory doing? just creating a dictionary?
Contributor
Author
There was a problem hiding this comment.
@MatthewPiatetsky yeah. It looks kind of silly here, but it cuts down on duplicate code elsewhere (when you only want to change one key, for example).
MatthewPiatetsky
approved these changes
Apr 3, 2017
rlucioni
force-pushed
the
renzo/grouping
branch
3 times, most recently
from
April 3, 2017 20:49
70cc29f to
599807b
Compare
Contributor
Author
|
@edx/learner-growth FYI. I've already gotten my review from @MatthewPiatetsky, this is more about showing off the new team handle. |
The meter now supports use with a single program, and can return serialized courses instead of counts when measuring progress. ECOM-6602
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meter now supports use with a single program, and can return serialized courses instead of counts when measuring progress.
ECOM-6602
These are the Python changes from https://github.com/edx/edx-platform/pull/14773, slightly modified so that the Waffle switch is respected.