Implement minor UI/A11Y fixes for outline - #14859
Conversation
There was a problem hiding this comment.
You might as well translate Course Outline here too.
75ab248 to
5b51d86
Compare
|
Current plan is to wait to merge this until https://github.com/edx/edx-platform/pull/14828 goes to master |
|
Sandbox is set up, ready for review. |
andy-armstrong
left a comment
There was a problem hiding this comment.
👍 nice set of clean ups! I have one minor comment that you can address if you like.
| @@ -1,3 +1,9 @@ | |||
| .outline-header { | |||
There was a problem hiding this comment.
There is no way for you to know this, but the course skeleton defines a page-title class that should be used for consistency:
https://outline-details.sandbox.edx.org/template/ux/reference/course-skeleton.html
|
I will connect with @cptvitamin around the section / subsection focus prior to merge to discuss how we handled this in the past for discussions. update: I can connect with mark next week, ok to keep that item as wontfix for now. 👍 from my standpoint. |
5f5cf58 to
1b27390
Compare
54985eb to
76d68c1
Compare
1b27390 to
68da899
Compare
8e6c118 to
196d379
Compare
68da899 to
8d56883
Compare
8d56883 to
89fc9fb
Compare
|
jenkins run js |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Wednesday, April 19, 2017. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Combined LEARNER-430 and LEARNER-333.
https://outline-details.sandbox.edx.org/courses/course-v1:edX+bj101+2017/course/
Search/Resume/Bookmarks region or not) and make the Topic levels (Introduction, Example Week 1, etc) Headings.
The title element (in the head) might also be changed to include Course Name Course Outline - Platform NameThis isn't possible inside of fragments, wontfixFocus border on section / subsection should not enable based on click (a11y review here as well)Mark S confirmed the only way he knows of to have the focus show for keyboard navigation but not for clicks is with a "super hacky" JavaScript library that we haven't vetted for performance or a11y, so IMO this is also a wontfix