Skip to content

Alex/add latex compiler key - #1514

Merged
auraz merged 1 commit into
masterfrom
alex/add_latex_compiler_key
Nov 4, 2013
Merged

Alex/add latex compiler key#1514
auraz merged 1 commit into
masterfrom
alex/add_latex_compiler_key

Conversation

@auraz

@auraz auraz commented Oct 28, 2013

Copy link
Copy Markdown
Contributor

Add latex_compiler_key to course settings.

True - will enable problem with latex templates.
False - will disable.

Problem or Html templates, which use latex, should have latex in their names.

Fix for https://edx-wiki.atlassian.net/browse/BLD-426

Special notes:
a) When course author open course (default value for use_latex_compiler is false), he does not see latex problems. Then he changes value to true. And if he will press back, that page will not reload and he will se old templates for advanced problems. He should reload page to see new advanced templates. Html templates are not affected.

@frrrances and @singingwolfboy please review

@ghost ghost assigned nedbat and auraz Oct 28, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary -- the teardown method of the test should always do this regardless.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singingwolfboy This comes from latest commit in master (this week), see Scenario: I can add Advanced Problem components. It was added by @jzoldak 28.10 in edx@380e7c4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an unfortunate and sub-obtimal pattern that we don't want to proliferate but are letting go for now. :(
Lettuce has hooks for after_step and after_scenario, but no hook for after_example. The right way to solve this, given the way we have set up our acceptance tests, is to add an after_example hook to our fork of lettuce and submit an upstream PR to the official repo.
I have created a ticket in the testeng backlog for this.

@frrrances

Copy link
Copy Markdown
Contributor

I'm not qualified to review the code, but moving LaTeX to advanced seems like a good idea. @cahrens tells me that some of the funky behavior is known so 👍

@nedbat

nedbat commented Nov 1, 2013

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@singingwolfboy

Copy link
Copy Markdown
Contributor

👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a comma after the last item?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants