Use XBlock handlers in the LMS ... - #1531
Conversation
|
looks like a lot of XModule unit tests are failing... eek |
|
Yeah, I'm working on that. The set of changes should be small, though. |
There was a problem hiding this comment.
seems like using quote_slashes is unnecessary for the string 'invalid Location'
|
Did a first-pass and it looks pretty good. Will do a more thorough pass when tests pass. Also consider having someone from Studio look at this - there are some CMS changes here. |
There was a problem hiding this comment.
Maybe I'm just not up on how the CMS will use handlers: is it a given that a handler in the CMS will imply "preview"? Or is this a misleading use of the word "preview"?
There was a problem hiding this comment.
No, you're right, this is preview only, and should be named that way.
|
Take care of a few things, and then 👍 |
There was a problem hiding this comment.
This multiline split doesn't seem right (closing paren on final line; would be neater to put the first dictionary entry on line 336 not 335) - split the same way it's split in test_peer_grading.py l 33
Why is input 5 intentionally left unset? I might prefer that in a comment above the declaration of valid_get_dict
4 participants
... and use them to implement ajax_url for XModule compatibility