Skip to content

a11y imporvements to wiki/history.html - #1543

Merged
symbolist merged 1 commit into
masterfrom
usman/lms1309-a11y-wiki-changes
Nov 7, 2013
Merged

a11y imporvements to wiki/history.html#1543
symbolist merged 1 commit into
masterfrom
usman/lms1309-a11y-wiki-changes

Conversation

@symbolist

Copy link
Copy Markdown
Contributor

https://edx-wiki.atlassian.net/browse/LMS-1309

  1. When a revision diff details are toggled on the focus is moved to the diff details div. Previously bootstrap collapse() was being used which changed the url anchor before displaying the corresponding details div causing screen readers to start reading from the start.
  2. Added scope attribute to th elements to associate header information with the cells. See http://www.w3.org/TR/html4/struct/tables.html#h-11.4.1 for details.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotate table cells.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows W3 table a11y syntax so, this lgtm...

@symbolist

Copy link
Copy Markdown
Contributor Author

@caesar2164 here is one for you too.. and @adampalay another one for you. :)

Comment thread lms/templates/wiki/history.html Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want to remove your dev console statement?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do when I rebase.

@caesar2164

Copy link
Copy Markdown
Contributor

Hi @symbolist this PR looks like a very good start. Before I ok it to merge, I'd like to see feedback from someone that better understands the JSON accordion loading (@adampalay ?) just to make sure that works as expected, but accessibility wise this seems to make a lot of sense...

@sarina

sarina commented Nov 6, 2013

Copy link
Copy Markdown
Contributor

@symbolist just a note - please put the JIRA ticket ID in your commit message going forward (ie

commit message

LMS-xxxx

This helps us compile our release notes.

@symbolist

Copy link
Copy Markdown
Contributor Author

Removed console.log() call, rebased, added ticket ID to commit message and tested on IE10+Jaws and ChromeVox.

@adampalay

Copy link
Copy Markdown
Contributor

👍

@caesar2164

Copy link
Copy Markdown
Contributor

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants