a11y imporvements to wiki/history.html - #1543
Conversation
There was a problem hiding this comment.
Annotate table cells.
There was a problem hiding this comment.
Follows W3 table a11y syntax so, this lgtm...
|
@caesar2164 here is one for you too.. and @adampalay another one for you. :) |
There was a problem hiding this comment.
probably want to remove your dev console statement?
There was a problem hiding this comment.
Will do when I rebase.
|
Hi @symbolist this PR looks like a very good start. Before I ok it to merge, I'd like to see feedback from someone that better understands the JSON accordion loading (@adampalay ?) just to make sure that works as expected, but accessibility wise this seems to make a lot of sense... |
|
@symbolist just a note - please put the JIRA ticket ID in your commit message going forward (ie This helps us compile our release notes. |
|
Removed console.log() call, rebased, added ticket ID to commit message and tested on IE10+Jaws and ChromeVox. |
|
👍 |
|
LGTM 👍 |
a11y imporvements to wiki/history.html
https://edx-wiki.atlassian.net/browse/LMS-1309