Skip to content

Update problem-builder requirement to 2.6.5patch2 to migrate keys. - #15862

Merged
feanil merged 1 commit into
openedx:masterfrom
open-craft:cliff/pb-migrate-keys
Aug 24, 2017
Merged

Update problem-builder requirement to 2.6.5patch2 to migrate keys.#15862
feanil merged 1 commit into
openedx:masterfrom
open-craft:cliff/pb-migrate-keys

Conversation

@jcdyer

@jcdyer jcdyer commented Aug 22, 2017

Copy link
Copy Markdown
Contributor

@feanil @fredsmith @bradenmacdonald

This pulls in open-craft/problem-builder#160, which provides a new script to run the key migration.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @jcdyer! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

Create an OSPR issue for this pull request.

@jcdyer

jcdyer commented Aug 22, 2017

Copy link
Copy Markdown
Contributor Author

Just to make sure the steps forward on this are clear:

  • This needs a second review from an edx employee. @fredsmith Can you do that?
  • I no longer have merge permissions on edx-platform, so once it gets the second thumb, can @feanil merge it?
  • The script should probably get a test run on stage. (@feanil) I'll be available for trouble shooting if needed.
  • Finally, it will need to be run on production (@feanil).

I can edit the above if there are more appropriate people to take on the particular tasks.

@feanil
feanil requested a review from fredsmith August 23, 2017 21:24
@feanil

feanil commented Aug 23, 2017

Copy link
Copy Markdown
Contributor

Just noticed @fredsmith was not tagged as a reviewer on this PR. Just tagged him, that should put this on his radar to review.

@jcdyer

jcdyer commented Aug 24, 2017

Copy link
Copy Markdown
Contributor Author

Thanks. I didn't realize you were using that functionality now.

@feanil
feanil merged commit d6e75a8 into openedx:master Aug 24, 2017
@feanil

feanil commented Aug 24, 2017

Copy link
Copy Markdown
Contributor

Test run on stage running now.

@jcdyer

jcdyer commented Aug 25, 2017

Copy link
Copy Markdown
Contributor Author

@feanil Was the test successful?

@feanil

feanil commented Aug 25, 2017

Copy link
Copy Markdown
Contributor

Test in stage was successful. This was deployed to production today. If I get some time this afternoon, I'll try to kick off the production migration before the weekend otherwise we'll kick it off next week.

@bradenmacdonald
bradenmacdonald deleted the cliff/pb-migrate-keys branch August 25, 2017 18:18
@feanil

feanil commented Aug 28, 2017

Copy link
Copy Markdown
Contributor

I've started the migration in production. At the current rate, it looks like it should finish in under an hour.

@jcdyer Once it's done, I think what we'll need, is to make a PR that removes the old column from the model but don't add the migration. Followed by the addition of the migration that will remove the old column. Sound right?

@feanil

feanil commented Aug 28, 2017

Copy link
Copy Markdown
Contributor

@jcdyer Migration complete in production.

mysql> select * from problem_builder_answer where course_key is NULL limit 1;
Empty set (0.01 sec)

@jcdyer

jcdyer commented Aug 28, 2017

Copy link
Copy Markdown
Contributor Author

That sounds right.

@bradenmacdonald

Copy link
Copy Markdown
Contributor

\o/ Thanks @feanil and @jcdyer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants