LEARNER-1860: Refactored course enrollment filtering. - #15899
Closed
robrap wants to merge 0 commit into
Closed
Conversation
robrap
commented
Aug 25, 2017
| def get_site_course_enrollments(user): | ||
| """ | ||
| Returns information about a user's course certificates. | ||
| Returns a user's enrollments filtered by the orgs of the current site. |
Contributor
Author
There was a problem hiding this comment.
Reviewers:
- I refactored this function to make it more clear.
- I had issues with my devstack, so I have not yet run this code.
- It is possible that this whitelist/blacklist code introduced a bug, but if we can get it right, it is a lot easier to understand.
andy-armstrong
approved these changes
Aug 28, 2017
andy-armstrong
left a comment
andy-armstrong
left a comment
Contributor
There was a problem hiding this comment.
@robrap this is a nice clean up, thanks! 👍 once you have the tests passing.
robrap
changed the title
Contributor
Author
|
Once I get back to this, I will try to get it in to https://github.com/edx/edx-platform/pull/15868 |
HarryRein
force-pushed
the
andya/profile-certificates
branch
from
August 30, 2017 15:45
19516d0 to
323acfe
Compare
andy-armstrong
force-pushed
the
andya/profile-certificates
branch
3 times, most recently
from
August 31, 2017 20:58
55ef371 to
44f7e16
Compare
Contributor
Author
|
We're not going to use this as-is, but we will use parts in https://openedx.atlassian.net/browse/LEARNER-2449. Closing this PR. |
Contributor
Author
|
FYI: Some of the refactoring for org filtering for sites was merged in this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEARNER-1860