Add search box to CourseEnrollmentAllowed admin interface.

[smarnach]

This adds a search field to the CourseEnrollmentAllowed admin interface, and configures the list view to show individual fields instead of a string representation of the whole instance.

JIRA tickets: OSPR-1943

Discussions: None

Dependencies: None

Screenshots:

Without this change:

With this change applied:

Sandbox URL: https://pr16166.sandbox.opencraft.hosting/

Merge deadline: None

Testing instructions:

Navigate to https://pr16166.sandbox.opencraft.hosting/admin/student/courseenrollmentallowed/, log in as the standard staff user and try it.

Author notes and concerns: None

Reviewers

• @cgopalan
• edX reviewer[s] TBD

[openedx-webhooks]

Thanks for the pull request, @smarnach! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

Create an OSPR issue for this pull request.

[openedx-webhooks]

Thanks for the pull request, @smarnach! I've created OSPR-1943 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

• supporting documentation
• edx-code email threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

[cgopalan]

Nit: It seems like all tuple and list definitions in the other classes also include a comma at the end. Maybe better to do that here too, for consistency.

[smarnach]

OK, changed that. (Some people prefer the trailing comma since it avoids a pitfall when reducing the length of the tuple to one. It's not done consistently in edx-platform, but seems to be done in this particular file.)

[smarnach]

@cgopalan The sandbox is now available – see the link in the PR description.

[cgopalan]

👍

• I tested this: Checked that the search field was visible and functional on the Student/Course Enrollment Allowed admin page.
• I read through the code
• I checked for accessibility issues
• Includes documentation

[cgopalan]

@smarnach seems like the jenkins/lettuce build failed. Not sure what the reason was. How do we trigger it again?

[smarnach]

jenkins run lettuce

[smarnach]

@cgopalan We can ask Jenkins to rerun the tests from the PR, but I'm not sure you would have permission.

[nedbat]

@smarnach Sorry for the delay. This looks like a simple improvement. @mjfrey would this fall into your area of expertise?

[smarnach]

@nedbat @mjfrey Could you please help me find a reviewer here? I think this change should be really uncontroversial and easy to review.

[mjfrey]

Thanks.

[smarnach]

@mjfrey Thanks!

[openedx-webhooks]

@smarnach 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, December 12, 2017.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the production environment.