Revert "Allow theme template block override" - #16708
Closed
jzoldak wants to merge 1 commit into
Closed
Conversation
Contributor
|
@jzoldak Ah, that's unfortunate, the 1771th one... The test file introduced mako-missing-default (although many other files also do). I'll open a PR for a quick fix, please don't revert :) |
Contributor
|
This is also probably a good time to fight down this linter debt overall. |
Contributor
|
Hopefully https://github.com/edx/edx-platform/pull/16709 fixes it. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, December 01, 2017. |
tuchfarber
deleted the
revert-15947-allow-theme-template-block-override
branch
November 30, 2017 19:53
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts edx/edx-platform#15947. It pushed us over the limit for xsslint violations, and master is now failing the quality build.
Please either quickly fix forward, or we should merge in this revert PR.
@bderusha @UmanShahzad