Implement journeys app banner. - #16823
Merged
waheedahmed merged 1 commit intoDec 8, 2017
Merged
Conversation
6 tasks
Contributor
Author
|
@edx/learner-spartans please review. |
Contributor
Author
|
jenkins run a11y |
Contributor
Author
|
Configuration PR: https://github.com/edx/configuration/pull/4241 |
ahsan-ul-haq
approved these changes
Dec 7, 2017
Banners will enable the deep linking functionality for mobile apps. LEARNER-2731
waheedahmed
force-pushed
the
waheed/LEARNER-2731-implement-journeys-app-banner
branch
from
December 8, 2017 13:34
a8f5faa to
3ed08e3
Compare
feanil
reviewed
Dec 8, 2017
| <% branch_key = static.get_value("BRANCH_IO_KEY", settings.BRANCH_IO_KEY) %> | ||
| % if branch_key: | ||
| <script type="text/javascript"> | ||
| (function(b,r,a,n,c,h,_,s,d,k){if(!b[n]||!b[n]._q){for(;s<_.length;)c(h,_[s++]);d=r.createElement(a);d.async=1;d.src="https://cdn.branch.io/branch-latest.min.js";k=r.getElementsByTagName(a)[0];k.parentNode.insertBefore(d,k);b[n]=h}})(window,document,"script","branch",function(b,r){b[r]=function(){b._q.push([r,arguments])}},{_q:[],_v:1},"addListener applyCode banner closeBanner creditHistory credits data deepview deepviewCta first getCode init link logout redeem referrals removeListener sendSMS setBranchViewData setIdentity track validateCode".split(" "), 0); |
Contributor
There was a problem hiding this comment.
If their CDN is down, what's the behavior of this? Will it block loading the whole page?
Contributor
Author
There was a problem hiding this comment.
@feanil No, it will not break the page. Tested locally by breaking the CDN url.
waheedahmed
deleted the
waheed/LEARNER-2731-implement-journeys-app-banner
branch
December 8, 2017 14:37
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Monday, December 11, 2017. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Banners will enable the deep linking functionality for mobile apps.
LEARNER-2731
Make sure that the following steps are done after merging:
BRANCH_KEYvariable in configuration repo