LEARNER-3469 - More registration form cleanup. - #16829
Merged
Merged
Conversation
dianakhuang
force-pushed
the
diana/registration-form-improvements
branch
2 times, most recently
from
December 7, 2017 21:02
90c8793 to
e849294
Compare
Contributor
|
I'm seeing label overlapping content when the browser pre-fills fields on your sandbox |
Contributor
|
I'm actually seeing it in production too (with an added error) |
Contributor
|
@dianakhuang is there already a bug ticket to resolve the pre-filled overlap issue? If it's a quick fix maybe you could add that to this PR? |
Contributor
Author
|
@AlasdairSwan hmm, it seems as though the autocomplete might be behaving wonkily. I will take a look at that. |
dianakhuang
force-pushed
the
diana/registration-form-improvements
branch
from
December 8, 2017 14:39
e849294 to
0ecc055
Compare
Contributor
Author
|
@AlasdairSwan fix for the autocomplete issue has been included. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Monday, December 11, 2017. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openedx.atlassian.net/browse/LEARNER-3469
Sandbox: https://dianakhuang.sandbox.edx.org/register