Skip to content

Updating xblock-review version to include commit for being more defen… #16846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dillon-Dumesnil merged 2 commits into from
Dec 8, 2017
Merged

Updating xblock-review version to include commit for being more defen… #16846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0def70e
Updating xblock-review version to include commit for being more defen…
Dillon-Dumesnil Dec 8, 2017
aa8b7ab
Fixing correctness text so it doesn't match 'correct' in the word 'co…
Dillon-Dumesnil Dec 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openedx/tests/xblock_integration/test_review_xblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,12 +363,13 @@ def test_review_problems(self, num_desired):
'section': review_section_actual.location.name,
}
))
print response

@jzoldak jzoldak Dec 8, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dillon-Dumesnil not sure you meant to leave this in there?

@Dillon-Dumesnil Dillon-Dumesnil Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... There's always something. One sec


expected_header_text = 'Review Problems'
# The problems are defaulted to correct upon load
# This happens because the problems "raw_possible" field is 0 and the
# "raw_earned" field is also 0.
expected_correctness_text = 'correct'
expected_correctness_text = ' correct '
expected_problems = ['Review Problem 1', 'Review Problem 2', 'Review Problem 3',
'Review Problem 4', 'Review Problem 5', 'Review Problem 6']

Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/github.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ git+https://github.com/edx/edx-user-state-client.git@1.0.2#egg=edx-user-state-cl
git+https://github.com/edx/xblock-lti-consumer.git@v1.1.6#egg=lti_consumer-xblock==1.1.6
git+https://github.com/edx/edx-proctoring.git@1.3.1#egg=edx-proctoring==1.3.1
# This is here because all of the other XBlocks are located here. However, it is published to PyPI and will be installed that way
xblock-review==1.1.1
xblock-review==1.1.2


# Third Party XBlocks
Expand Down