Fix retries logic in award program certificate task - #16900
Merged
tasawernawaz merged 1 commit intoDec 14, 2017
Merged
Conversation
bderusha
suggested changes
Dec 13, 2017
bderusha
left a comment
bderusha
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. One addition requested
| retry = True | ||
| else: | ||
| LOGGER.exception("Max retries exceeded. {msg}".format(msg=warning_message)) | ||
| LOGGER.warning('Failed to award certificate for program {uuid} to user {username}.'.format( |
Contributor
There was a problem hiding this comment.
I think that this looks good. Can we also add an additional warning if this is the last attempt
if self.request.retries == MAX_RETRIES:
LOGGER.exception('Final attempt to award certificate for program %s to user %s failed', program_uuid, username)
Contributor
There was a problem hiding this comment.
::EDIT::
Actually I think this may not be necessary as you mentioned in the other PR. But we should update our alerting to capture whatever error message is output when MaxRetriesExceededError is thrown
Contributor
There was a problem hiding this comment.
bderusha
approved these changes
Dec 13, 2017
tasawernawaz
deleted the
tasawer/learner-3165-fix-retries-logic-in-award-program-certificate
branch
December 14, 2017 07:15
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, December 19, 2017. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEARNER-3165
Previous PR: #16822
@bderusha Please review.