Skip to content

Fixed password reset message - #1693

Merged
flowerhack merged 3 commits into
masterfrom
flowerhack/fix/password-reset-messages
Nov 19, 2013
Merged

Fixed password reset message#1693
flowerhack merged 3 commits into
masterfrom
flowerhack/fix/password-reset-messages

Conversation

@flowerhack

Copy link
Copy Markdown
Contributor

Not sure who to tag for something like this, so let me know if there's anyone more advisable! @dianakhuang @nedbat

LMS-1507

@dianakhuang

Copy link
Copy Markdown
Contributor

Looks like you need to make sure that the password reset tests are also updated. 😉

@wedaly

wedaly commented Nov 19, 2013

Copy link
Copy Markdown
Contributor

@flowerhack All the unit tests are passing, but the documentation tests are failing. I have to admit I've never seen that happen before. Here's the traceback from the console: https://gist.github.com/wedaly/7538145

Does the command rake builddocs succeed locally?

@flowerhack

Copy link
Copy Markdown
Contributor Author

Heh. I actually noticed this as I was leaving today and planned to ask you about it in the morning, as I thought it was odd too. I'll let you know tomorrow about rake builddocs.

@flowerhack

Copy link
Copy Markdown
Contributor Author

@nedbat @dianakhuang

@nedbat

nedbat commented Nov 19, 2013

Copy link
Copy Markdown
Contributor

👍

@dianakhuang

Copy link
Copy Markdown
Contributor

👍 🚢

flowerhack pushed a commit that referenced this pull request Nov 19, 2013
@flowerhack
flowerhack merged commit bc4ebfd into master Nov 19, 2013
@flowerhack
flowerhack deleted the flowerhack/fix/password-reset-messages branch November 19, 2013 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants