Test HTML returned from view methods for "i4X". - #1697
Merged
Conversation
Contributor
There was a problem hiding this comment.
It'd be worthwhile to have a comment here saying that the check is to ensure the test is meaningful or something like that. (Just in case someone says, "there's no verticals in the source for ____" they should then say, "oh, that makes this test a noop")
Contributor
|
👍 seems reasonable. Not sure if it's exhaustive and we'll need to be vigilant about uncommenting the commented out calls (not sure how we police that) |
STUD-941
cahrens
pushed a commit
that referenced
this pull request
Nov 20, 2013
Test HTML returned from view methods for "i4X".
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 31, 2017
* Revert "Revert "Add the validation of the release date before 1900 openedx#1611" (openedx#1691)" This reverts commit d8fa2f6. * Delete input event handler for the validation of the release date before 1900 openedx#1611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I still have to allow "View Live" links which have a jump_to to the old course ID (on port 8000).
@dmitchell Here's another quick one to review. Let me know if you think there is a better way to search for old locations (besides just looking for "i4X").