Add template block to allow redefining the course details section in themes - #17543
Conversation
|
Thanks for the pull request, @clemente! I've created OSPR-2266 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information. |
jcdyer
left a comment
There was a problem hiding this comment.
Indentation on this file is misleading. Please fix the nesting of the <%block> marker. Otherwise, this is good to go.
There was a problem hiding this comment.
There's an indentation issue here. The </div> on line 221 closes the div.details on L211, not the div.container on L210. Move the <%block name="course_about_details"> inside the div.container
There was a problem hiding this comment.
Thanks for noticing it. The original </div> already had the wrong indentation. I corrected it and also moved the %block inside the div.container as suggested.
b8e384e to
6288926
Compare
|
Looks good to me. Will merge |
|
@clemente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, February 27, 2018. |
|
Thanks. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
This PR is very similar to https://github.com/edx/edx-platform/pull/17091
It adds a
<%block>that we needed to redefine in a theme.The block name is prefixed with the template name to avoid clashes.
Pinging @tuchfarber (reviewer of that previous PR). Very simple PR.
JIRA tickets: N/A
Discussions: None
Dependencies: None
Screenshots:
Sandbox URL: None.
Partner information: N/A
Deployment targets: N/A
Merge deadline: None
Testing instructions: None required
Author notes and concerns: N/A
Reviewers
Settings
None