Use singular transcript util to retrieve transcripts from contentstore - #17851
Use singular transcript util to retrieve transcripts from contentstore#17851Qubad786 wants to merge 4 commits into
Conversation
|
FYI @muhammad-ammar. |
|
Your PR has finished running tests. |
|
Your PR has finished running tests. |
|
@muhammad-ammar I am updating sandbox. |
|
This is ready for the review. |
|
jenkins run python |
|
Your PR has finished running tests. |
muhammad-ammar
left a comment
muhammad-ammar
left a comment
There was a problem hiding this comment.
@Qubad786 I have concerns over these changes. Please see me inline comments.
| get_or_create_sjson, | ||
| generate_sjson_for_all_speeds, | ||
| get_video_transcript_content, | ||
| get_transcript_from_contentstore, |
There was a problem hiding this comment.
shouldn't we need to use get_transcript instead of get_transcript_from_contentstore?
There was a problem hiding this comment.
Nope, I am only aiming for contentstore part of the interface. So that we may find some further unseen scenario(i.e. not covered by our util).
| response.content_type = transcript_mime_type | ||
| response.content_type = mime_type | ||
|
|
||
| elif dispatch.startswith('available_translations'): |
There was a problem hiding this comment.
Changes in this file are different from what we did in https://github.com/edx/edx-platform/pull/17718. Is this intentionally? Changes in the https://github.com/edx/edx-platform/pull/17718 are final and should be used.
There was a problem hiding this comment.
@muhammad-ammar this is temporary just to make sure that our contentstore part of the interface works as smooth as it should be! :)
|
jenkins run bokchoy |
|
Your PR has finished running tests. |
3 participants
sandbox: https://tools-edx-jenkins.edx.org/job/Sandboxes/job/CreateSandbox/9741/console