Update the get_transcript util with html5_sources by mushtaqak · Pull Request #17976 · openedx/openedx-platform

mushtaqak · 2018-04-17T12:35:20Z

Update the get_transcript util with html5_sources

EDUCATOR-2746

edx-status-bot · 2018-04-17T13:04:20Z

Your PR has finished running tests.

edx-status-bot · 2018-04-17T13:37:55Z

Your PR has finished running tests.

edx-status-bot · 2018-04-20T14:14:43Z

Your PR has finished running tests.

edx-status-bot · 2018-04-23T14:42:14Z

Your PR has finished running tests.

edx-status-bot · 2018-04-23T15:16:33Z

Your PR has finished running tests.

edx-status-bot · 2018-04-24T07:37:03Z

Your PR has finished running tests.

edx-status-bot · 2018-04-24T14:33:33Z

Your PR has finished running tests.

mushtaqak · 2018-04-25T06:21:57Z

jenkins run all

edx-status-bot · 2018-04-25T07:03:55Z

Your PR has finished running tests.

muhammad-ammar

LGTM 👍 just one minor comment

muhammad-ammar · 2018-04-25T07:15:24Z

-    except KeyError:
-        raise NotFoundError
+    possible_sub_ids = [youtube_id, sub, video.youtube_id_1_0] + get_html5_ids(video.html5_sources)
+    for sub_id in possible_sub_ids:


what about for sub_id in set(possible_sub_ids): to avoid duplicates?

set reorders the element in ascending order which is what we don't want.

mushtaqak · 2018-04-25T12:46:43Z

jenkins run all

edx-status-bot · 2018-04-25T12:50:23Z

Your PR has finished running tests.

edx-status-bot · 2018-04-25T12:56:15Z

Your PR has finished running tests.

mushtaqak · 2018-04-25T13:00:53Z

jenkins run all

edx-status-bot · 2018-04-25T13:09:53Z

Your PR has finished running tests.

edx-status-bot · 2018-04-25T13:21:21Z

Your PR has finished running tests.

mushtaqak · 2018-04-25T13:25:31Z

jenkins run bokchoy

mushtaqak · 2018-04-25T13:25:39Z

jenkins run quality

mushtaqak · 2018-04-25T13:25:48Z

jenkins run python

edx-status-bot · 2018-04-25T13:30:31Z

Your PR has finished running tests.

mushtaqak · 2018-04-25T13:31:00Z

jenkins run python

edx-status-bot · 2018-04-25T13:36:40Z

Your PR has finished running tests.

edx-status-bot · 2018-04-25T13:50:50Z

Your PR has finished running tests.

edx-status-bot · 2018-04-25T13:51:45Z

Your PR has finished running tests.

mushtaqak · 2018-04-25T14:05:42Z

jenkins run bokchoy

mushtaqak · 2018-04-25T14:05:59Z

jenkins run python

mushtaqak · 2018-04-25T14:25:43Z

jenkins run python

mushtaqak · 2018-04-25T14:25:55Z

jenkins run bokchoy

edx-status-bot · 2018-04-25T15:14:19Z

Your PR has finished running tests.

muhammad-ammar · 2018-04-25T15:21:11Z

@mushtaqak build passed and green

edx-status-bot · 2018-04-25T17:26:20Z

Your PR has finished running tests.

mushtaqak changed the base branch from master to ammar/EDUCATOR-1759-delete-transcript-from-advance-tab April 17, 2018 12:55

mushtaqak force-pushed the mushtaq/html5_sources_transcript branch from 81d69e3 to ec00c22 Compare April 17, 2018 13:05

muhammad-ammar force-pushed the ammar/EDUCATOR-1759-delete-transcript-from-advance-tab branch 2 times, most recently from f2b499e to 82d0968 Compare April 23, 2018 13:45

mushtaqak force-pushed the mushtaq/html5_sources_transcript branch from c07d57a to f5f2b19 Compare April 23, 2018 14:11

mushtaqak force-pushed the mushtaq/html5_sources_transcript branch from a24eb23 to a28b9bb Compare April 24, 2018 07:00

mushtaqak requested a review from muhammad-ammar April 24, 2018 07:02

muhammad-ammar force-pushed the ammar/EDUCATOR-1759-delete-transcript-from-advance-tab branch from 82d0968 to d5758bd Compare April 24, 2018 11:50

mushtaqak force-pushed the mushtaq/html5_sources_transcript branch from a28b9bb to e0cbe78 Compare April 24, 2018 14:03

muhammad-ammar approved these changes Apr 25, 2018

View reviewed changes

Update the get_transcript util with html5_sources - EDUCATOR-2651

b181e6b

mushtaqak force-pushed the mushtaq/html5_sources_transcript branch from e0cbe78 to b181e6b Compare April 25, 2018 12:43

mushtaqak changed the base branch from ammar/EDUCATOR-1759-delete-transcript-from-advance-tab to transcripts-phase-2 April 25, 2018 12:43

mushtaqak merged commit 1ba833f into transcripts-phase-2 Apr 25, 2018

mushtaqak deleted the mushtaq/html5_sources_transcript branch April 25, 2018 16:41

Uh oh!

Conversation

mushtaqak commented Apr 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edx-status-bot commented Apr 17, 2018

Uh oh!

edx-status-bot commented Apr 17, 2018

Uh oh!

edx-status-bot commented Apr 20, 2018

Uh oh!

edx-status-bot commented Apr 23, 2018

Uh oh!

edx-status-bot commented Apr 23, 2018

Uh oh!

edx-status-bot commented Apr 24, 2018

Uh oh!

edx-status-bot commented Apr 24, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

muhammad-ammar left a comment

Choose a reason for hiding this comment

Uh oh!

muhammad-ammar Apr 25, 2018

Choose a reason for hiding this comment

Uh oh!

mushtaqak Apr 25, 2018

Choose a reason for hiding this comment

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

mushtaqak commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

muhammad-ammar commented Apr 25, 2018

Uh oh!

edx-status-bot commented Apr 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

mushtaqak commented Apr 17, 2018 •

edited

Loading