Skip to content

OAuth2 Per-Application Scopes - #18317

Closed
douglashall wants to merge 1 commit into
masterfrom
douglashall/oauth_scopes
Closed

OAuth2 Per-Application Scopes#18317
douglashall wants to merge 1 commit into
masterfrom
douglashall/oauth_scopes

Conversation

@douglashall

Copy link
Copy Markdown
Contributor

No description provided.

@douglashall
douglashall force-pushed the douglashall/oauth_scopes branch 20 times, most recently from 6951c45 to f9e1b32 Compare June 12, 2018 21:21
@douglashall
douglashall force-pushed the douglashall/oauth_scopes branch from f9e1b32 to 0764de2 Compare June 13, 2018 17:44
@douglashall
douglashall force-pushed the douglashall/oauth_scopes branch 8 times, most recently from cfbc4c1 to 7028e7d Compare June 18, 2018 16:42
@douglashall
douglashall force-pushed the douglashall/oauth_scopes branch 9 times, most recently from ddf6fd7 to 17ab2ff Compare June 19, 2018 20:38
@douglashall
douglashall force-pushed the douglashall/oauth_scopes branch from 17ab2ff to f255d8f Compare June 19, 2018 21:24
@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. The following contexts failed:

  • jenkins/python
  • jenkins/a11y
  • jenkins/bokchoy

@openedx openedx deleted a comment from douglashall Jun 19, 2018

from django.contrib.auth import get_user_model
from django.http import Http404
from edx_rest_framework_extensions.permissions import (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes need to be included in the v1 of the Grades API - and not part of v0.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Catch!

@mettursathish

mettursathish commented Jun 20, 2018

Copy link
Copy Markdown

Thank @douglashall! As promised, we were working on migration script(sql) and authorize.html changes. The python migration code looks good, you can incorporate authorize.html code which displays the organization filter(if applicable) from the below commit edx@fdc9e0e. Also merged as part of this PR https://github.com/edx/edx-platform/pull/18117

@nasthagiri

Copy link
Copy Markdown
Contributor

@mettursathish Should that commit include the authorize.html file?

@mettursathish

Copy link
Copy Markdown

@douglashall, @nasthagiri
Instead of making changes to the authorize.html; the approach was to append the scope description. If OAuth client_Id is associated with the organization filter; then append organization name with scope description at the suffix. By this approach, we have little more flexibility of the description which is getting displayed in authorize.html. Also, profile scope, email scope is generic to the open edX instance and not specific to any organization. So, the idea of appending the scope description makes it easier. Attaching the screenshot for reference.

scope_grades

@nasthagiri

Copy link
Copy Markdown
Contributor

This was closed in favor of https://github.com/edx/edx-platform/pull/18408

@nedbat
nedbat deleted the douglashall/oauth_scopes branch May 27, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants