Fixes to database columns - #1840
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hope you don't mind the drive-by comment. If I understand correctly, we have been inadvertently truncating anonymous ids in the database, right?
If so, with this check to see if they match, wouldn't all truncated values that were saved to DB always fail. If so, do we want to do this "log as error and continue" the right thing to do?
Do we expect a significant number of truncated pieces of data to already be in the prod database?
Contributor
There was a problem hiding this comment.
The db migration will remove all rows with a truncated id, so by the time this code runs, there will be no short ids any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.