Update logging.getLogger() calls to use edx instead of mitx - #1846
Merged
Conversation
Contributor
|
Looks good to me, so long as someone from analytics gives it a nod as well |
Contributor
Author
|
@rocha Can you take a look and verify that this looks good? |
Contributor
|
This generally looks fine to me, my only note / concern is that somebody somewhere is configuring the 'mitx' logger and expecting those settings to be inherited by all 'mitx.*' loggers. I'm not sure what our prod logger settings look like but we should be sure to update those settings as well (if necessary). |
Contributor
|
LGTM 🚀 In this case, the changes are not related to analytics. It is confusing because we have been using the term |
singingwolfboy
added a commit
that referenced
this pull request
Dec 4, 2013
Update logging.getLogger() calls to use edx instead of mitx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of #1815