FED Cleanup of Studio Outline page - #1896
Conversation
|
@frrrances, I'm still going through - but I noticed I can't cancel out of creating a new subsection (cancel button doesn't fire any events). |
|
@frrrances, also, it looks like the modal depths visuals are applied backwards (the modal window has the blur filter applied and the background is clear). See this screengrab: |
|
@frrrances, the padding of the "New Section" UI looks like it was increased with this work (see screengrab). Can you tighten this up? |
|
@frrrances, also, looks like the "Collapse/Expand All Sections" visually toggles something (height or padding) with the "New Section" UI - not sure if this was happening before or not. |
There was a problem hiding this comment.
We already have elements/_modal.scss. While the Sass in there is part of the older base we want to refactor, should the contents of this file be included there for future maintenance rather than another file?
There was a problem hiding this comment.
Good catch. This is meant to be part of the subset of modals for form actions, so I wanted to use the _uploads.scss file but it isn't named well, so I made a new one and we should merge them into a single _modal-forms.scss file. For now is it okay to leave this as is?
4 participants
This is a FED cleanup of the Studio Outline page. @talbs and @cahrens can you review?