Hotfix/2013 12 12 - #1937
Merged
Merged
Conversation
added 2 commits
December 12, 2013 12:35
Contributor
There was a problem hiding this comment.
Use find_one instead, so that if there are many, you don't actually ship them all back from the db.
Contributor
There was a problem hiding this comment.
find_one won't handle the else clause which looks for any without a run id.
Contributor
There was a problem hiding this comment.
The else clause immediately throws away everything but the first entry of maps, so find_one should work fine, I would think.
Contributor
There was a problem hiding this comment.
Oh, my bad. I misread the code
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.