Remove all references to datadog from our code. - #19420
Merged
Merged
Conversation
dianakhuang
force-pushed
the
diana/remove-datadog
branch
from
December 11, 2018 18:43
57b3e02 to
06f50e1
Compare
dianakhuang
force-pushed
the
diana/remove-datadog
branch
3 times, most recently
from
January 7, 2019 21:48
6bf3d7e to
2adfd13
Compare
dianakhuang
changed the title
robrap
reviewed
Jan 8, 2019
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
Excited to have all this code removed soon. Thanks @dianakhuang.
robrap
approved these changes
Jan 8, 2019
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
Looks almost good to go. One minor clean-up. Thanks.
Contributor
There was a problem hiding this comment.
The pragma should also be removed. :)
dianakhuang
force-pushed
the
diana/remove-datadog
branch
from
January 8, 2019 20:41
a19f2ae to
6572d99
Compare
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Thursday, January 10, 2019. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
pomegranited
referenced
this pull request
in open-craft/openedx-platform
Jan 28, 2019
pomegranited
referenced
this pull request
in open-craft/openedx-platform
Jan 28, 2019
pomegranited
referenced
this pull request
in open-craft/openedx-platform
Feb 7, 2019
pomegranited
referenced
this pull request
in open-craft/openedx-platform
Feb 18, 2019
Agrendalath
added a commit
to open-craft/openedx-platform
that referenced
this pull request
Sep 21, 2022
This attribute is already deprecated for XBlocks in favour of directly retrieving it like `block.scope_ids.usage_id.context_key`. This commit also removes some redundant logging code which was omitted in the Datadog removal in openedx#19420.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of DEPR-9