Skip to content

Cache anonymous user id on the user object, so that queries aren't made many times over during module rendering #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpennington merged 1 commit into from
Dec 13, 2013
Merged

Cache anonymous user id on the user object, so that queries aren't made many times over during module rendering #1945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions common/djangoapps/student/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ def anonymous_id_for_user(user, course_id):
if user.is_anonymous():
return None

cached_id = getattr(user, '_anonymous_id', {}).get(course_id)
if cached_id is not None:
return cached_id

# include the secret key as a salt, and to make the ids unique across different LMS installs.
hasher = hashlib.md5()
hasher.update(settings.SECRET_KEY)
Expand Down Expand Up @@ -94,6 +98,11 @@ def anonymous_id_for_user(user, course_id):
# continue
pass

if not hasattr(user, '_anonymous_id'):
user._anonymous_id = {}

user._anonymous_id[course_id] = digest

return digest


Expand Down