Skip to content

Anton/allow arbitrary regex in stringresponse - #1948

Merged
auraz merged 1 commit into
masterfrom
anton/allow-arbitrary-regex-in-stringresponse
Jan 15, 2014
Merged

Anton/allow arbitrary regex in stringresponse#1948
auraz merged 1 commit into
masterfrom
anton/allow-arbitrary-regex-in-stringresponse

Conversation

@auraz

@auraz auraz commented Dec 13, 2013

Copy link
Copy Markdown
Contributor

This is for https://edx-wiki.atlassian.net/browse/BLD-475: Allow arbitrary regex inside of string response and updates for multiple answers for string response.

Add mode to markdown editor: if first answer is started with | -> that will be regexp.

@Lyla-Fischer @polesye @nedbat Please review.
@srpearce this PR contains documentation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well fix "areintended" while you're here.... :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok )

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: Might as well fix "areintended" while you're here.... :)

@auraz

auraz commented Dec 24, 2013

Copy link
Copy Markdown
Contributor Author

@nedbat I've addressed all your comments. Please continue review.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use camelCase (firstAnswer instead first_answer).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@auraz

auraz commented Dec 24, 2013

Copy link
Copy Markdown
Contributor Author

@polesye all your comments are addressed.

@polesye

polesye commented Dec 24, 2013

Copy link
Copy Markdown
Contributor

👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add these four files, please. They are due to a known problem on master, but should not be added.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were added accidentally through negligence. Thanks, fixed: "Don't add these four files, please. "

@nedbat

nedbat commented Jan 13, 2014

Copy link
Copy Markdown
Contributor

I can finish the review when the semantics of the regex match have been finished.

@auraz

auraz commented Jan 14, 2014

Copy link
Copy Markdown
Contributor Author

@nedbat All your comments are addressed, please continue review.

@nedbat

nedbat commented Jan 14, 2014

Copy link
Copy Markdown
Contributor

👍

auraz added a commit that referenced this pull request Jan 15, 2014
…ngresponse

Anton/allow arbitrary regex in stringresponse
@auraz
auraz merged commit cbe97d6 into master Jan 15, 2014
@auraz
auraz deleted the anton/allow-arbitrary-regex-in-stringresponse branch January 15, 2014 11:15
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants