Fix auth email configuration - #1952
Merged
Merged
Conversation
Fix bug introduced by openedx#1919: usage of not-yet-defined AUTH_TOKENS dict.
Contributor
|
looks good to me. |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
…1952) * Add transaction control for mask-user command. openedx#1950 * Fix review myself.
0x29a
added a commit
to open-craft/openedx-platform
that referenced
this pull request
Dec 7, 2020
…penedx#1952) * Prototype implementation of user progress merging * Add new outcome, add locks for rows, remove one todo * Rename functions * Rename file with tests * Add mail sending, some refactoring/renaming * Finish tests, add url * Minor improvements * Add tests for view, add logging, fix view * Fix pylint warning * Update docs, add missed assert, fix debug status code Co-authored-by: Paulo Viadanna <paulo@opencraft.com>
shimulch
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 26, 2021
…penedx#1952) * Prototype implementation of user progress merging * Add new outcome, add locks for rows, remove one todo * Rename functions * Rename file with tests * Add mail sending, some refactoring/renaming * Finish tests, add url * Minor improvements * Add tests for view, add logging, fix view * Fix pylint warning * Update docs, add missed assert, fix debug status code Co-authored-by: Paulo Viadanna <paulo@opencraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced a bug in #1919, this fixes it.
@feanil, could you please check this?