Skip to content

script bombs if comments include unicode - #1997

Merged
e0d merged 2 commits into
masterfrom
e0d/unicode-bug
Dec 20, 2013
Merged

script bombs if comments include unicode#1997
e0d merged 2 commits into
masterfrom
e0d/unicode-bug

Conversation

@e0d

@e0d e0d commented Dec 19, 2013

Copy link
Copy Markdown
Contributor

@cpennington

./scripts/release.py --previous 25958e87a2ee687ecd7d76e6a94739172714bc45 --current a78400a8d887aedc025aeb7d0490bcdf29be48e4 --date 2013-12-18
Traceback (most recent call last):
  File "./scripts/release.py", line 167, in <module>
    main()
  File "./scripts/release.py", line 164, in main
    print(generate_table(commit_range, include_merge=args.merge))
  File "./scripts/release.py", line 111, in generate_table
    verified="",
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 25: ordinal not in range(128)


.encode('ascii',errors='ignore')

@cpennington

Copy link
Copy Markdown
Contributor

Can we instead just change the script to use unicode objects internally? In particular, that would mean prepending u to the table format string on line 106, and the "\n" on line 113.

@singingwolfboy

Copy link
Copy Markdown
Contributor

👍

e0d pushed a commit that referenced this pull request Dec 20, 2013
script bombs if comments include unicode
@e0d
e0d merged commit 67b9075 into master Dec 20, 2013
@e0d
e0d deleted the e0d/unicode-bug branch December 20, 2013 19:10
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants